[investigate] ABI #2317
Closed
[investigate] ABI #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehowl
reviewed
Oct 2, 2024
There was a problem hiding this comment.
So, from a first look this seems to want to encode a communication between Go and Gno? Maybe replacing the behaviour currently happening in gno.land/sdk/vm/keeper?
I'm not really sure; in any case, I see this PR is old and largely outdated. Let's discuss what you're thinking of and what you need, keeping in mind that:
- we want to improve the result of MsgCall, by changing the return arguments to be full JSON representations of the gno objects: feat(keeper): handle JSON arguments in
MsgCall#1776 - there's an ABI specification being worked on for client-realm communication: docs: Add Realm ABI Specification #2833
|
Feel free to open up another issue to discuss what you want to do here, etc.; but I think this warrants discussion to decide what we want and why we need it. Just doing some PR spring-cleaning :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: write some description